[Mesa-dev] [PATCH v2 07/14] etnaviv: drop calls to etna_compatible_rs_format(..)

Christian Gmeiner christian.gmeiner at gmail.com
Tue May 1 14:48:36 UTC 2018


etna_compatible_rs_format(..) was called before translate_rs_format(..)
which reduced the used formats somewhat. The following table shows
the affected pipe formats with compatible format and the value from
the format table:

PIPE_FORMAT_B8G8R8X8_UNORM:  com: 0x6 - tbl: 0x5
PIPE_FORMAT_B5G5R5A1_UNORM:  com: 0x1 - tbl: 0x3
PIPE_FORMAT_B5G6R5_UNORM:    com: 0x1 - tbl: 0x4
PIPE_FORMAT_B8G8R8X8_SRGB:   com: 0x6 - tbl: 0x5
PIPE_FORMAT_B5G5R5X1_UNORM:  com: 0x1 - tbl: 0x2
PIPE_FORMAT_R8G8B8X8_UNORM:  com: 0x6 - tbl: 0x5
PIPE_FORMAT_B4G4R4X4_UNORM:  com: 0x1 - tbl: 0x0

All the other pipe_format -> rs_format conversation where equal.

No piglit regressions but lot of fixed ones.

Signed-off-by: Christian Gmeiner <christian.gmeiner at gmail.com>
---
 src/gallium/drivers/etnaviv/etnaviv_rs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/etnaviv/etnaviv_rs.c b/src/gallium/drivers/etnaviv/etnaviv_rs.c
index 08bc334dea..69b144acea 100644
--- a/src/gallium/drivers/etnaviv/etnaviv_rs.c
+++ b/src/gallium/drivers/etnaviv/etnaviv_rs.c
@@ -575,8 +575,8 @@ etna_try_rs_blit(struct pipe_context *pctx,
       return FALSE;
    }
 
-   unsigned src_format = etna_compatible_rs_format(blit_info->src.format);
-   unsigned dst_format = etna_compatible_rs_format(blit_info->dst.format);
+   unsigned src_format = blit_info->src.format;
+   unsigned dst_format = blit_info->dst.format;
    if (translate_rs_format(src_format) == ETNA_NO_MATCH ||
        translate_rs_format(dst_format) == ETNA_NO_MATCH ||
        blit_info->scissor_enable ||
-- 
2.17.0



More information about the mesa-dev mailing list