[Mesa-dev] [PATCH] radv: Allow vkEnumerateInstanceVersion ProcAddr without instance.

[Jason Ekstrand]

We solve the issue differently but I just verified that it is a problem and
also broken in anv and this looks correct to me.

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

Now you can review my patch. :-P

On Tue, May 1, 2018 at 9:06 AM, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
wrote:

> Apparently the somewhere between 1.1.70 and 1.1.73 the loader started
> depending on this. The loader then creates a 1.0 instance, which gets
> into funny situation because we have a 1.1 device.
>
> No idea how to do line wrapping in Mako though, my random guesses
> did not work.
>
> CC: 18.1 <mesa-stable at lists.freedesktop.org>
> ---
>  src/amd/vulkan/radv_entrypoints_gen.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_entrypoints_gen.py b/src/amd/vulkan/radv_
> entrypoints_gen.py
> index 8eb18e64b64..892491e6c30 100644
> --- a/src/amd/vulkan/radv_entrypoints_gen.py
> +++ b/src/amd/vulkan/radv_entrypoints_gen.py
> @@ -205,7 +205,7 @@ radv_entrypoint_is_enabled(int index, uint32_t
> core_version,
>     % if not e.device_command:
>        if (device) return false;
>     % endif
> -   % if e.name == 'vkCreateInstance' or e.name == '
> vkEnumerateInstanceExtensionProperties' or e.name == '
> vkEnumerateInstanceLayerProperties':
> +   % if e.name == 'vkCreateInstance' or e.name == '
> vkEnumerateInstanceExtensionProperties' or e.name == '
> vkEnumerateInstanceLayerProperties' or e.name ==
> 'vkEnumerateInstanceVersion':
>        return !device;
>     % elif e.core_version:
>        return instance && ${e.core_version.c_vk_version()} <=
> core_version;
> --
> 2.17.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180501/5079cb0c/attachment.html>