[Mesa-dev] [PATCH v2] i965: Fix ETC2/EAC GetCompressed* functions on Gen7 GPUs

Andres Gomez agomez at igalia.com
Wed May 2 12:19:37 UTC 2018


On Mon, 2018-03-19 at 16:56 +0200, Eleni Maria Stea wrote:
> Gen 7 GPUs store the compressed EAC/ETC2 images in other non-compressed
> formats that can render. When GetCompressed* functions are called, the
> pixels are returned in the non-compressed format that is used for the
> rendering.
> 
> With this patch we store both the compressed and non-compressed versions
> of the image, so that both rendering commands and GetCompressed*
> commands work.
> 
> Also, the assertions for GL_MAP_WRITE_BIT and GL_MAP_INVALIDATE_RANGE_BIT
> in intel_miptree_map_etc function have been removed because when the
> miptree is mapped for reading (for example from a GetCompress*
> function) the GL_MAP_WRITE_BIT won't be set (and shouldn't be set).
> 
> Fixes: the following test in CTS for gen7:
> KHR-GL45.direct_state_access.textures_compressed_subimage test
> 
> v2: fixes issues:
>    a) initialized uninitialized variables (Juan A. Suarez, Andres Gomez)
>    b) fixed race condition where mt and cmt were mapped at the same time
>    c) fixed indentation issues (Andres Gomez)

The commit log, AFAIU, should also include the line below:

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104272

-- 
Br,

Andres


More information about the mesa-dev mailing list