[Mesa-dev] [PATCH 02/10] i965: perf: sklgt2: drop special programming for pre-production stepping

[Kenneth Graunke]

On Friday, May 4, 2018 7:52:45 AM PDT Lionel Landwerlin wrote:
> Production steppings don't need this anymore.
> 
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_oa_sklgt2.xml | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_oa_sklgt2.xml b/src/mesa/drivers/dri/i965/brw_oa_sklgt2.xml
> index ba52a63f06d..3a528135070 100644
> --- a/src/mesa/drivers/dri/i965/brw_oa_sklgt2.xml
> +++ b/src/mesa/drivers/dri/i965/brw_oa_sklgt2.xml
> @@ -1,5 +1,5 @@
>  <?xml version="1.0"?>
> -<metrics version="1520268607" merge_md5="">
> +<metrics version="1520268929" merge_md5="">
>    <set name="Render Metrics Basic Gen9"
>         mdapi_supported_apis="OGL OCL IO BB"
>         underscore_name="render_basic"
> @@ -818,7 +818,7 @@
>    <set name="Compute Metrics Basic Gen9"
>         mdapi_supported_apis="OGL4 OCL IO BB"
>         underscore_name="compute_basic"
> -       hw_config_guid="fe47b29d-ae51-423e-bff4-27d965a95b60"
> +       hw_config_guid="9ae1360b-8036-4af0-943a-27460801d981"
>         chipset="SKLGT2"
>         symbol_name="ComputeBasic"
>         >
> @@ -1514,12 +1514,6 @@
>          <register type="NOA" address="0x00009888" value="0x53901111" />
>          <register type="NOA" address="0x00009840" value="0x00000080" />
>      </register_config>
> -    <register_config type="NOA"
> -                     availability="$SliceMask 0x02 AND $SkuRevisionId 0x02 ULT &&"
> -                     priority="2"
> -                     >
> -        <register type="NOA" address="0x00009840" value="0x00000000" />
> -    </register_config>
>      <register_config type="OA">
>          <register type="OA" address="0x00002710" value="0x00000000" />
>          <register type="OA" address="0x00002714" value="0x00800000" />
> 

I cannot find any documentation at all indicating that 0x80 can be
changed to 0 on modern Skylakes...register 0x9840 only appears to be
documented on Broadwell.  At any rate, I was able to confirm that
Skylake PCI ID rev 02 appears to be preproduction, and shouldn't exist,
so I think this is fine to drop.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180504/9669b9d0/attachment.sig>