[Mesa-dev] [RFC PATCH] gallium: add interface for EQAA

[Nicolai Hähnle]

On 01.05.2018 22:48, Marek Olšák wrote:
>         +**nr_color_samples**: This is the number of color samples for
>         EQAA, while
>         +``nr_samples`` is the number of coverage samples. If the format
>         is Z/S,
>         +``nr_color_samples`` is ignored. Constraints:
>         +* ``nr_color_samples`` must not be greater than ``nr_samples``.
>         +* If ``nr_color_samples`` is equal to ``nr_samples``, it is
>         called MSAA.
>         +* If ``nr_color_samples`` is less than ``nr_samples``, it is
>         called EQAA.
>         +* If ``nr_color_samples`` is equal to 1, the behavior of the
>         resolve blit is
>         +driver-dependent.
> 
> 
>     Why the last buller?
> 
> 
> Because we can support N >= 2 coverage samples and 1 color sample.

Okay, but for EQAA the behavior of the resolve blit is driver-dependent 
also when there are >= 2 color samples, because you can still have 
samples whose color fragment was discarded.


>     Also, are all state trackers expected to set nr_color_samples
>     correctly? This probably only affects nine, but still, it needs to
>     be kept in mind.
> 
> 
> Yes.

Makes sense to me.

Cheers,
Nicolai



> 
> Marek
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.