[Mesa-dev] [PATCH 1/8] i965: Re-emit depth/stencil/hiz on BRW_NEW_AUX_STATE

[Jason Ekstrand]

On Tue, May 8, 2018 at 8:19 AM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> On Tuesday, May 8, 2018 8:07:36 AM PDT Jason Ekstrand wrote:
> > On Mon, May 7, 2018 at 11:44 PM, Kenneth Graunke <kenneth at whitecape.org>
> > wrote:
> >
> > > On Monday, May 7, 2018 12:49:32 PM PDT Jason Ekstrand wrote:
> > > > ---
> > > >  src/mesa/drivers/dri/i965/gen7_misc_state.c | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/src/mesa/drivers/dri/i965/gen7_misc_state.c
> > > b/src/mesa/drivers/dri/i965/gen7_misc_state.c
> > > > index 1ce7658..1508473 100644
> > > > --- a/src/mesa/drivers/dri/i965/gen7_misc_state.c
> > > > +++ b/src/mesa/drivers/dri/i965/gen7_misc_state.c
> > > > @@ -195,7 +195,8 @@ const struct brw_tracked_state gen7_depthbuffer
> = {
> > > >        .mesa = _NEW_BUFFERS |
> > > >                _NEW_DEPTH |
> > > >                _NEW_STENCIL,
> > > > -      .brw = BRW_NEW_BATCH |
> > > > +      .brw = BRW_NEW_AUX_STATE |
> > > > +             BRW_NEW_BATCH |
> > > >               BRW_NEW_BLORP,
> > > >     },
> > > >     .emit = brw_emit_depthbuffer,
> > > >
> > >
> > > Changes like this warrant an explanation - is this fixing any known
> > > issues?  Found by inspection?
> > >
> > > I was surprised to see this, as BRW_NEW_AUX_STATE is usually about
> color
> > > surfaces - CCS_E compression, CCS_D fast clears...not HiZ.  But I see
> > > that intel_miptree_make_shareable might deal with HiZ...as does depth
> > > clear values...as does set_aux_state...so it certainly seems plausible.
> > >
> > > Still, I'm curious to know if you were thinking of anything specific.
> > >
> >
> > No, I don't know of anything specific.  I found it while I was working on
> > the rest of this series and thought it seemed off.  In particular, if we
> do
> > a trivial depth clear clear (which doesn't actually clear but just
> changes
> > the clear color), we may not get 3DSTATE_CLEAR_PARAMS updated.
> >
>
> Ahh, right, that includes 3DSTATE_CLEAR_PARAMS...we probably do want
> this then.  Maybe record that and some hand waving in the commit
> message.
>

I've added the following:

    Certain things can change the aux usage or fast clear color of a depth
    surface and we want to re-emit if that happens.  For instance, if you do
    a fast depth clear of an already clear depth surface, we will just set
    the clear color and not do anything else.  In that case, we could fail
    to re-emit 3DSTATE_CLEAR_PARAMS and not get the new fast-clear color.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180508/a2b3ae20/attachment-0001.html>