[Mesa-dev] [PATCH 2/5] gallium: add support for programmable sample locations

[Marek Olšák]

It looks like get_sample_position should be in pipe_screen too, but you
don't have to worry about that.

Marek

On Wed, May 9, 2018 at 9:26 AM, Rhys Perry <pendingchaos02 at gmail.com> wrote:

> It was put in pipe_context because get_sample_position was there. It's
> not really a strong reason to have it there though, so I'll put it in
> pipe_screen.
>
> On Wed, May 9, 2018 at 2:37 AM, Marek Olšák <maraeo at gmail.com> wrote:
> > BTW, is there any reason for get_sample_pixel_grid to be in
> pipe_context? It
> > seems that pipe_screen is a better place, because the returned values are
> > immutable. pipe_context also doesn't like functions that return
> something,
> > because it limits multithreading.
> >
> > Marek
> >
> > On Tue, May 8, 2018 at 9:32 PM, Marek Olšák <maraeo at gmail.com> wrote:
> >>
> >> The cso_context changes are unnecessary. It looks like that meta ops
> don't
> >> enable MSAA, so they are unaffected by sample locations, and thus no
> need to
> >> have any code for them in cso_context.
> >>
> >> The names don't have to use the _state suffix, i.e.
> set_sample_locations.
> >>
> >> I wouldn't add struct pipe_sample_locations. The whole array can be
> passed
> >> to set_sample_locations via a pointer, and NULL can mean disabled.
> >>
> >> Marek
> >
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180509/2e97b501/attachment.html>