[Mesa-dev] [PATCH v2] android: enable VK_ANDROID_native_buffer

[Tapani Pälli]

On 05/17/2018 10:23 AM, Jason Ekstrand wrote:
> Ok, so long as the current build isn't broken without it, rb.

Well TBH it does not compile but I thought you wanted the change to come 
as a pull from upstream header. I can put it back here temporarily or 
just later update the header.

> On May 17, 2018 00:16:44 Tapani Pälli <tapani.palli at intel.com> wrote:
> 
>> On 05/17/2018 09:38 AM, Jason Ekstrand wrote:
>>> What happened to the vk_icd.h bit?
>>
>> That's going here:
>> https://github.com/KhronosGroup/Vulkan-Headers/pull/2
>>
>>> On May 16, 2018 22:30:55 Tapani Pälli <tapani.palli at intel.com> wrote:
>>>
>>>> Patch changes entrypoints generator to not skip this extension even
>>>> though it is set as disabled in the xml. We also need compilation
>>>> flag VK_USE_PLATFORM_ANDROID_KHR to be enabled.
>>>>
>>>> It looks like this extension got disabled in commit 69f447553c.
>>>>
>>>> v2: just remove the whole 'supported' attrib check + remove
>>>>    vk_icd.h compilation fix (fix in VulkanHeaders instead)
>>>>
>>>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>>>> ---
>>>> Android.common.mk                       | 1 +
>>>> src/intel/vulkan/anv_entrypoints_gen.py | 3 ---
>>>> 2 files changed, 1 insertion(+), 3 deletions(-)
>>>>
>>>> diff --git a/Android.common.mk b/Android.common.mk
>>>> index e8aed48c31..999e17789b 100644
>>>> --- a/Android.common.mk
>>>> +++ b/Android.common.mk
>>>> @@ -73,6 +73,7 @@ LOCAL_CFLAGS += \
>>>>     -DHAVE_ENDIAN_H \
>>>>     -DHAVE_ZLIB \
>>>>     -DMAJOR_IN_SYSMACROS \
>>>> +    -DVK_USE_PLATFORM_ANDROID_KHR \
>>>>     -fvisibility=hidden \
>>>>     -Wno-sign-compare
>>>>
>>>> diff --git a/src/intel/vulkan/anv_entrypoints_gen.py
>>>> b/src/intel/vulkan/anv_entrypoints_gen.py
>>>> index d603ac1b20..230671d36a 100644
>>>> --- a/src/intel/vulkan/anv_entrypoints_gen.py
>>>> +++ b/src/intel/vulkan/anv_entrypoints_gen.py
>>>> @@ -495,9 +495,6 @@ def get_entrypoints(doc, entrypoints_to_defines,
>>>> start_index):
>>>>         if ext_name not in supported_exts:
>>>>             continue
>>>>
>>>> -        if extension.attrib['supported'] != 'vulkan':
>>>> -            continue
>>>> -
>>>>         ext = supported_exts[ext_name]
>>>>         ext.type = extension.attrib['type']
>>>>
>>>> -- 
>>>> 2.14.3
>>>>
>>>> _______________________________________________
>>>> mesa-dev mailing list
>>>> mesa-dev at lists.freedesktop.org
>>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>>
>>>
>>>
> 
> 
>