[Mesa-dev] [PATCH] radv: only pass the global BO list at submit time if enabled

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu May 17 09:57:00 UTC 2018


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Thu, May 17, 2018 at 11:36 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> That way the winsys might use a faster path when the global
> BO list is NULL.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/vulkan/radv_device.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index a7f4a5ab7b..9f87e7ef1e 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -2474,6 +2474,8 @@ VkResult radv_QueueSubmit(
>
>                 for (uint32_t j = 0; j < pSubmits[i].commandBufferCount; j += advance) {
>                         struct radeon_winsys_cs *initial_preamble = (do_flush && !j) ? initial_flush_preamble_cs : initial_preamble_cs;
> +                       const struct radv_winsys_bo_list *bo_list = NULL;
> +
>                         advance = MIN2(max_cs_submission,
>                                        pSubmits[i].commandBufferCount - j);
>
> @@ -2483,12 +2485,14 @@ VkResult radv_QueueSubmit(
>                         sem_info.cs_emit_wait = j == 0;
>                         sem_info.cs_emit_signal = j + advance == pSubmits[i].commandBufferCount;
>
> -                       if (unlikely(queue->device->use_global_bo_list))
> +                       if (unlikely(queue->device->use_global_bo_list)) {
>                                 pthread_mutex_lock(&queue->device->bo_list.mutex);
> +                               bo_list = &queue->device->bo_list.list;
> +                       }
>
>                         ret = queue->device->ws->cs_submit(ctx, queue->queue_idx, cs_array + j,
>                                                         advance, initial_preamble, continue_preamble_cs,
> -                                                       &sem_info, &queue->device->bo_list.list,
> +                                                       &sem_info, bo_list,
>                                                         can_patch, base_fence);
>
>                         if (unlikely(queue->device->use_global_bo_list))
> --
> 2.17.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list