[Mesa-dev] [PATCH] radv: pass radv_nir_compiler_options directly to create_llvm_function()

Timothy Arceri tarceri at itsqueeze.com
Fri May 18 08:52:43 UTC 2018


Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 18/05/18 18:43, Samuel Pitoiset wrote:
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/amd/vulkan/radv_nir_to_llvm.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c
> index 1384bf0bdba..9b9619b877e 100644
> --- a/src/amd/vulkan/radv_nir_to_llvm.c
> +++ b/src/amd/vulkan/radv_nir_to_llvm.c
> @@ -480,7 +480,7 @@ create_llvm_function(LLVMContextRef ctx, LLVMModuleRef module,
>                        unsigned num_return_elems,
>   		     struct arg_info *args,
>   		     unsigned max_workgroup_size,
> -		     bool unsafe_math)
> +		     const struct radv_nir_compiler_options *options)
>   {
>   	LLVMTypeRef main_function_type, ret_type;
>   	LLVMBasicBlockRef main_function_body;
> @@ -516,7 +516,7 @@ create_llvm_function(LLVMContextRef ctx, LLVMModuleRef module,
>   						     "amdgpu-max-work-group-size",
>   						     max_workgroup_size);
>   	}
> -	if (unsafe_math) {
> +	if (options->unsafe_math) {
>   		/* These were copied from some LLVM test. */
>   		LLVMAddTargetDependentFunctionAttr(main_function,
>   						   "less-precise-fpmad",
> @@ -1106,8 +1106,7 @@ static void create_function(struct radv_shader_context *ctx,
>   
>   	ctx->main_function = create_llvm_function(
>   	    ctx->context, ctx->ac.module, ctx->ac.builder, NULL, 0, &args,
> -	    ctx->max_workgroup_size,
> -	    ctx->options->unsafe_math);
> +	    ctx->max_workgroup_size, ctx->options);
>   	set_llvm_calling_convention(ctx->main_function, stage);
>   
>   
> 


More information about the mesa-dev mailing list