[Mesa-dev] [PATCH 0/3] egl/android: Remove dependencies on specific grallocs

[Tomasz Figa]

Hi Rob,

On Thu, May 24, 2018 at 8:23 PM Robert Foss <robert.foss at collabora.com>
wrote:

> Hey,

> I don't think I've received any feedback on this version yet.
> If anyone has some time to spare, it would be nice to get it merged.

Really sorry for taking so long to review. Posted my comments just now.

Best regards,
Tomasz


> Just to be clear about the libdrm branch linked in the cover letter,
> it is not required. Only for virgl platforms which happens to be what
> I tested on.


> Rob.

> On 2018-05-11 15:47, Robert Foss wrote:
> > This series replaces the dependency on
> > GRALLOC_MODULE_PERFORM_GET_DRM_FD with DRM node
> > probing and disables the support for drm_gralloc.
> >
> > The series has been tested on Qemu+AOSP, where a
> > virtio gpu was successfully probed for and
> > opened.
> >
> > This however required adding support in libdrm
> > for virtio gpus, and virtio buses. An initial
> > patch for this can be found here:
> >
> > https://gitlab.collabora.com/robertfoss/libdrm/tree/virtio_rfc
> >
> > Changes since v1:
> >   - Added fix for build issue
> >   - Do not rely on libdrm for probing
> >   - Distinguish between errors and when no drm devices are found
> >
> > Changes since RFC:
> >   - Rebased work on the libdrm patch [2].
> >   - Included patch from Rob Herring disabling drm_gralloc/flink
> >     support by default.
> >   - Added device handler driver probing.
> >
> >
> > Rob Herring (1):
> >    egl/android: #ifdef out flink name support
> >
> > Robert Foss (2):
> >    gallium/util: Fix build error due to cast to different size
> >    egl/android: Add DRM node probing and filtering
> >
> >   src/egl/Android.mk                            |   6 +-
> >   src/egl/drivers/dri2/egl_dri2.h               |   2 -
> >   src/egl/drivers/dri2/platform_android.c       | 206 ++++++++++++++----
> >   .../auxiliary/util/u_debug_stack_android.cpp  |   4 +-
> >   4 files changed, 174 insertions(+), 44 deletions(-)
> >