[Mesa-dev] [PATCH 2/2] st/mesa: handle GL_UNSIGNED_INT64_ARB in st_pipe_vertex_format

Nicolai Hähnle nhaehnle at gmail.com
Mon May 28 09:29:33 UTC 2018


On 25.05.2018 23:03, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> Bindless texture handles can be passed via vertex attribs using this type.
> This fixes a bunch of bindless piglit tests on radeonsi.
> 
> Cc: 18.0 18.1 <mesa-stable at lists.freedesktop.org>
> ---
>   src/mesa/state_tracker/st_atom_array.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/src/mesa/state_tracker/st_atom_array.c b/src/mesa/state_tracker/st_atom_array.c
> index 9a0935e21a5..76dc81975c8 100644
> --- a/src/mesa/state_tracker/st_atom_array.c
> +++ b/src/mesa/state_tracker/st_atom_array.c
> @@ -292,20 +292,23 @@ st_pipe_vertex_format(const struct gl_array_attributes *attrib)
>         assert(size == 3 && !integer && format == GL_RGBA);
>         return PIPE_FORMAT_R11G11B10_FLOAT;
>   
>      case GL_UNSIGNED_BYTE:
>         if (format == GL_BGRA) {
>            /* this is an odd-ball case */
>            assert(normalized);
>            return PIPE_FORMAT_B8G8R8A8_UNORM;
>         }
>         break;
> +
> +   case GL_UNSIGNED_INT64_ARB:
> +      return PIPE_FORMAT_R32G32_UINT;

Is it not possible to have vectors of uint64 as attributes?

Cheers,
Nicolai


>      }
>   
>      index = integer*2 + normalized;
>      assert(index <= 2);
>      assert(type >= GL_BYTE && type <= GL_FIXED);
>      return vertex_formats[type - GL_BYTE][index][size-1];
>   }
>   
>   static void init_velement(struct pipe_vertex_element *velement,
>                             int src_offset, int format,
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list