[Mesa-dev] [PATCH] radv: Only expose subgroups shuflles on VI+.

[Samuel Pitoiset]

why?

On 05/30/2018 08:52 AM, Bas Nieuwenhuizen wrote:
> Fixes: f2c6a550611 "radv: enable subgroup capabilities"
> ---
>   src/amd/vulkan/radv_device.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
> index 61b4fba23f8..93b6e611067 100644
> --- a/src/amd/vulkan/radv_device.c
> +++ b/src/amd/vulkan/radv_device.c
> @@ -963,9 +963,12 @@ void radv_GetPhysicalDeviceProperties2(
>   							VK_SUBGROUP_FEATURE_BASIC_BIT |
>   							VK_SUBGROUP_FEATURE_BALLOT_BIT |
>   							VK_SUBGROUP_FEATURE_QUAD_BIT |
> -							VK_SUBGROUP_FEATURE_SHUFFLE_BIT |
> -							VK_SUBGROUP_FEATURE_SHUFFLE_RELATIVE_BIT |
>   							VK_SUBGROUP_FEATURE_VOTE_BIT;
> +			if (pdevice->rad_info.chip_class >= VI) {
> +				properties->supportedOperations |=
> +							VK_SUBGROUP_FEATURE_SHUFFLE_BIT |
> +							VK_SUBGROUP_FEATURE_SHUFFLE_RELATIVE_BIT;
> +			}
>   			properties->quadOperationsInAllStages = true;
>   			break;
>   		}
>