[Mesa-dev] [PATCH] nir: fix alarming comment

Kenneth Graunke kenneth at whitecape.org
Thu May 31 17:07:53 UTC 2018

On Thursday, May 31, 2018 3:57:04 AM PDT Bas Nieuwenhuizen wrote:
> On Thu, May 31, 2018 at 11:57 AM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
> > safe -> precision safe
> I'd argue this would be the wrong fix. I would consider issues with
> infinity and NaN not to be precision issues, so saying precision safe
> only muddles the water.

Agreed, I'd write "Many of these optimizations don't handle NaN or
infinity correctly." if you don't like the current comment.

Feel free to put my ack on such a change.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180531/a6e58d63/attachment.sig>

More information about the mesa-dev mailing list