[Mesa-dev] [PATCH mesa 1/3] egl: rewire the build systems to use libwayland-egl
emil.l.velikov at gmail.com
Thu May 31 17:22:32 UTC 2018
On 29 May 2018 at 15:41, Eric Engestrom <eric.engestrom at intel.com> wrote:
> Cc: Emil Velikov <emil.l.velikov at gmail.com>
> Cc: Daniel Stone <daniels at collabora.com>
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> A couple things worth mentioning:
> - I chose to add libwayland-egl as a separate dependency for EGL rather
> than bumping the libwayland required version, so that old libwayland
> can still be used if EGL is not needed. I'm happy to squash those if
> we'd rather simply bump the libwayland version.
> - There is one non-build-system change in there, in platform_wayland.c,
> because the wayland-egl-backend.h we had and the one in wayland have
> diverged (for C++ compatibility IIRC, which we didn't need). I'm
> thinking it might be best to split this out as a separate change
> before the move in this commit, but it would probably involve so much
> changes (like the testing scripts) that I preferred to just squash it
> in here.
IMHO keeping Wayland 1.15 optional is fine for the time being. I would
strongly recommend we make it compulsory around the 18.2 branch point.
a) devs using master will be less frustrated when their distro is missing 1.15
b) less code and no "hidden" dependency that sometimes cause problems
Since there's a handful of bits that need sorting, I'm re-spinning the series.
I will send it to the backburner in a couple of minutes and it will be
on the list ~10 mins later.
More information about the mesa-dev