[Mesa-dev] [PATCH 1/3] ac/nir: make use of i1false in few more places

Dave Airlie airlied at gmail.com
Thu Nov 1 00:10:15 UTC 2018


For this one:

Reviewed-by: Dave Airlie <airlied at redhat.com>
On Tue, 30 Oct 2018 at 02:04, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/amd/common/ac_nir_to_llvm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c
> index 5ab81987d0..e5fbe003f5 100644
> --- a/src/amd/common/ac_nir_to_llvm.c
> +++ b/src/amd/common/ac_nir_to_llvm.c
> @@ -1570,7 +1570,7 @@ static LLVMValueRef visit_atomic_ssbo(struct ac_nir_context *ctx,
>                                                  true);
>         params[arg_count++] = ctx->ac.i32_0; /* vindex */
>         params[arg_count++] = get_src(ctx, instr->src[1]);      /* voffset */
> -       params[arg_count++] = LLVMConstInt(ctx->ac.i1, 0, false);  /* slc */
> +       params[arg_count++] = ctx->ac.i1false;  /* slc */
>
>         switch (instr->intrinsic) {
>         case nir_intrinsic_ssbo_atomic_add:
> @@ -2594,7 +2594,7 @@ static void emit_discard(struct ac_nir_context *ctx,
>                                      ctx->ac.i32_0, "");
>         } else {
>                 assert(instr->intrinsic == nir_intrinsic_discard);
> -               cond = LLVMConstInt(ctx->ac.i1, false, 0);
> +               cond = ctx->ac.i1false;
>         }
>
>         ctx->abi->emit_kill(ctx->abi, cond);
> @@ -2652,7 +2652,7 @@ visit_first_invocation(struct ac_nir_context *ctx)
>         LLVMValueRef active_set = ac_build_ballot(&ctx->ac, ctx->ac.i32_1);
>
>         /* The second argument is whether cttz(0) should be defined, but we do not care. */
> -       LLVMValueRef args[] = {active_set, LLVMConstInt(ctx->ac.i1, 0, false)};
> +       LLVMValueRef args[] = {active_set, ctx->ac.i1false};
>         LLVMValueRef result =  ac_build_intrinsic(&ctx->ac,
>                                                   "llvm.cttz.i64",
>                                                   ctx->ac.i64, args, 2,
> --
> 2.19.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list