[Mesa-dev] [PATCH] r600/sb: Fix constant logical operand in assert.
Gert Wollny
gert.wollny at collabora.com
Thu Nov 1 09:14:30 UTC 2018
Good catch,
Reviewed-By: Gert Wollny <gert.wollny at collabora.com>
Am Mittwoch, den 31.10.2018, 15:40 -0700 schrieb Vinson Lee:
> Fixes: da977ad90747 ("r600/sb: start adding GDS support")
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
> ---
> src/gallium/drivers/r600/sb/sb_bc_builder.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/r600/sb/sb_bc_builder.cpp
> b/src/gallium/drivers/r600/sb/sb_bc_builder.cpp
> index 5681fdc44253..b7d87eac9f42 100644
> --- a/src/gallium/drivers/r600/sb/sb_bc_builder.cpp
> +++ b/src/gallium/drivers/r600/sb/sb_bc_builder.cpp
> @@ -567,7 +567,7 @@ int bc_builder::build_fetch_gds(fetch_node *n) {
> const fetch_op_info *fop = bc.op_ptr;
> unsigned gds_op = (ctx.fetch_opcode(bc.op) >> 8) & 0x3f;
> unsigned mem_op = 4;
> - assert(fop->flags && FF_GDS);
> + assert(fop->flags & FF_GDS);
>
> if (bc.op == FETCH_OP_TF_WRITE) {
> mem_op = 5;
More information about the mesa-dev
mailing list