[Mesa-dev] [PATCH 09/12] gallivm: remove workarounds for pre LLVM 5.0

Jose Fonseca jfonseca at vmware.com
Thu Nov 1 10:06:16 UTC 2018


On 31/10/2018 13:30, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> With LLVM 5.0.1 the minimum required version, we can drop all the dead
> code.
> 
> Cc: Roland Scheidegger <sroland at vmware.com>
> Cc: Jose Fonseca <jfonseca at vmware.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Gents this is a quick and dirty grep job. A couple of places may need
> the comments to be tweaked/dropped - I've annotated those with XXX.

[..]

Nice cleanup. Thanks.

Could you please re-indent the # pragma for DEBUG macro.  Otherwise 
looks perfect.  I'm also OK leaving the XXX comments for now and revisit 
later.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>

Jose



More information about the mesa-dev mailing list