[Mesa-dev] [PATCH] egl: Fix eglentrypoint.h sort order.

[Eric Engestrom]

On Thursday, 2018-11-01 16:56:50 +0100, Mathias Fröhlich wrote:
> Hi Michel,
> 
> > > There seems to be a failure with the latest patches you pushed.
> > > The patch fixes a failure with the sort order in egl symbols.
> > 
> > Well, now it's broken with other locales. :)
> > 
> > I guess src/egl/egl-entrypoint-check itself should make sure sort runs
> > with locale settings resulting in the expected order.
> 
> I was just about to send something, when Eric sent something.

Pushed now, but travis still fails:
https://travis-ci.org/mesa3d/mesa/jobs/449405406

I'm really confused here, because the LANG is now fixed, so it shouldn't
behave differently on different environments?

If anyone has any clue, I'm all ears :)

> 
> Out of curiosity, which locale does invert the capitals with respect
> to ascii number ordering?

I think pretty much every "human language" locale considers lowercase
and uppercase to be the same letter, which means "DevicesEXT" comes
before "DeviceStringEXT". Nothing's inverted, is just that "devicese"
comes before "devicest". LANG=C behaves differently because it looks at
the ASCII order.

> 
> Do I also remember right that the reson for sorting was a binary
> search being done on the names for getprocaddress or something?

That's exactly right :)

> So, the ascii table sorting matters, right?

Not sure what you mean? Are you talking about this issue, or something
else?

> 
> > BTW, this kind of commentary should be after the --- line, otherwise
> > it's considered part of the commit log by Git tools.
> 
> Ok, thanks!
> Well I should have mentioned, that I usually check if git just rebases fine on a
> branch when it is pushed. And that sent series did not get just eaten up by
> the pushed variant on rebase.
> 
> best
> 
> Mathias
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev