[Mesa-dev] [PATCH mesa] egl: use the LC_ALL hammer instead of LANG

[Michel Dänzer]

On 2018-11-01 5:57 p.m., Eric Engestrom wrote:
> Some environment (like Travis apparently) set LC_* vars, messing up the
> sort ordering, so let's use envvar with the highest priority to make
> sure this is actually sorted in ASCII order.
> 
> Suggested-by: Michel Dänzer <michel at daenzer.net>
> Fixes: b42dc50a5f1b22103b26 "egl: fix entrypoint sorting test"
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
> Verified, this actually fixes travis:
> https://travis-ci.org/1ace/mesa/jobs/449427385
> ---
>  src/egl/egl-entrypoint-check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/egl/egl-entrypoint-check b/src/egl/egl-entrypoint-check
> index bb7d6a777a71be5842fc..d6a42722a44c7ed4a5cd 100755
> --- a/src/egl/egl-entrypoint-check
> +++ b/src/egl/egl-entrypoint-check
> @@ -7,5 +7,5 @@ then
>  fi
>  
>  entrypoints=$(grep EGL_ENTRYPOINT "$srcdir"/main/eglentrypoint.h)
> -sorted=$(LANG=C sort <<< "$entrypoints")
> +sorted=$(LC_ALL=C sort <<< "$entrypoints")
>  test "$entrypoints" = "$sorted"
> 

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>

Thanks Eric!


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer