[Mesa-dev] [PATCH v3] autotools: library-dependency when no sse and 32-bit
Dylan Baker
dylan at pnwbakers.com
Mon Nov 5 16:52:01 UTC 2018
Thanks!
Quoting Lionel Landwerlin (2018-11-05 04:25:40)
> Done. Thanks!
>
> On 05/11/2018 11:04, Sergii Romantsov wrote:
>
> Could, please, somebody push?
>
> On Thu, Nov 1, 2018 at 6:11 PM Dylan Baker <dylan at pnwbakers.com> wrote:
>
> Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
>
> Quoting Sergii Romantsov (2018-11-01 04:02:43)
> > Building of 32bit Mesa may fail if __SSE__ is not specified.
> > Added missed dependency from libm.
> >
> > v2: avoided dependecy on any flag, just link
> >
> > v3: meson doesn't fail, but have added dependency on libm
> >
> > CC: Dylan Baker <dylan at pnwbakers.com>
> > CC: Lionel G Landwerlin <lionel.g.landwerlin at intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108560
> > Signed-off-by: Sergii Romantsov <sergii.romantsov at globallogic.com>
> > ---
> > src/util/Makefile.am | 3 ++-
> > src/util/meson.build | 2 +-
> > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/util/Makefile.am b/src/util/Makefile.am
> > index d79f2b3..85c7553 100644
> > --- a/src/util/Makefile.am
> > +++ b/src/util/Makefile.am
> > @@ -60,7 +60,8 @@ libmesautil_la_LIBADD = \
> > $(PTHREAD_LIBS) \
> > $(CLOCK_LIB) \
> > $(ZLIB_LIBS) \
> > - $(LIBATOMIC_LIBS)
> > + $(LIBATOMIC_LIBS) \
> > + -lm
> >
> > libxmlconfig_la_SOURCES = $(XMLCONFIG_FILES)
> > libxmlconfig_la_CFLAGS = \
> > diff --git a/src/util/meson.build b/src/util/meson.build
> > index 49d84c1..5b82b21 100644
> > --- a/src/util/meson.build
> > +++ b/src/util/meson.build
> > @@ -113,7 +113,7 @@ libmesa_util = static_library(
> > 'mesa_util',
> > [files_mesa_util, format_srgb],
> > include_directories : inc_common,
> > - dependencies : [dep_zlib, dep_clock, dep_thread, dep_atomic],
> > + dependencies : [dep_zlib, dep_clock, dep_thread, dep_atomic,
> dep_m],
> > c_args : [c_msvc_compat_args, c_vis_args],
> > build_by_default : false
> > )
> > --
> > 2.7.4
> >
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
>
> --
> Sergii Romantsov
> GlobalLogic Inc.
> www.globallogic.com
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181105/515426de/attachment.sig>
More information about the mesa-dev
mailing list