[Mesa-dev] [PATCH] mesa: expose NV_conditional_render on GLES

[Erik Faye-Lund]

On Mon, 2018-11-05 at 12:29 -0500, Ilia Mirkin wrote:
> I doesn't need ES 3.0, just EXT_occlusion_query_boolean, which mesa
> happens to support.

Whoops, I don't know how I missed that fact. Yeah, you're right, ES 2.0
should be enough.

> Are there any drivers that support conditional
> render but not ARB_occlusion_query? (I don't think that's really
> possible given that the feature is basically designed for occlusion
> queries...)

I don't think so, no.

> On Mon, Nov 5, 2018 at 12:26 PM Erik Faye-Lund
> <erik.faye-lund at collabora.com> wrote:
> > The extension spec has been updated to include GLES 3 support, so
> > let's
> > enable it there.
> > 
> > Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
> > ---
> > 
> > This patch can be tested with this piglit-series:
> > https://patchwork.freedesktop.org/series/52039/
> > 
> >  src/mapi/glapi/gen/NV_conditional_render.xml | 4 ++--
> >  src/mesa/main/extensions_table.h             | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/src/mapi/glapi/gen/NV_conditional_render.xml
> > b/src/mapi/glapi/gen/NV_conditional_render.xml
> > index 926b2629412..8f375ee46cf 100644
> > --- a/src/mapi/glapi/gen/NV_conditional_render.xml
> > +++ b/src/mapi/glapi/gen/NV_conditional_render.xml
> > @@ -13,12 +13,12 @@
> >      <enum name="QUERY_BY_REGION_WAIT_NV"     value="0x8E15"/>
> >      <enum name="QUERY_BY_REGION_NO_WAIT_NV"  value="0x8E16"/>
> > 
> > -    <function name="BeginConditionalRenderNV"
> > alias="BeginConditionalRender">
> > +    <function name="BeginConditionalRenderNV"
> > alias="BeginConditionalRender" es2="3.0">
> >         <param name="query" type="GLuint"/>
> >         <param name="mode" type="GLenum"/>
> >      </function>
> > 
> > -    <function name="EndConditionalRenderNV"
> > alias="EndConditionalRender">
> > +    <function name="EndConditionalRenderNV"
> > alias="EndConditionalRender" es2="3.0">
> >      </function>
> > 
> >  </category>
> > diff --git a/src/mesa/main/extensions_table.h
> > b/src/mesa/main/extensions_table.h
> > index a516a1b17f8..720091c5c17 100644
> > --- a/src/mesa/main/extensions_table.h
> > +++ b/src/mesa/main/extensions_table.h
> > @@ -345,7 +345,7 @@ EXT(MESA_ycbcr_texture                      ,
> > MESA_ycbcr_texture
> >  EXT(NVX_gpu_memory_info                     ,
> > NVX_gpu_memory_info                    , GLL, GLC,  x ,  x , 2013)
> > 
> >  EXT(NV_blend_square                         ,
> > dummy_true                             , GLL,  x ,  x ,  x , 1999)
> > -EXT(NV_conditional_render                   ,
> > NV_conditional_render                  , GLL, GLC,  x ,  x , 2008)
> > +EXT(NV_conditional_render                   ,
> > NV_conditional_render                  , GLL, GLC,  x ,  30, 2008)
> >  EXT(NV_conservative_raster                  ,
> > NV_conservative_raster                 , GLL, GLC, ES1, ES2, 2015)
> >  EXT(NV_conservative_raster_dilate           ,
> > NV_conservative_raster_dilate          , GLL, GLC, ES1, ES2, 2015)
> >  EXT(NV_conservative_raster_pre_snap         ,
> > NV_conservative_raster_pre_snap        , GLL, GLC, ES1, ES2, 2017)
> > --
> > 2.19.1
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev