[Mesa-dev] [PATCH] intel/decoders: fix instruction base address parsing

Kenneth Graunke kenneth at whitecape.org
Mon Nov 5 21:24:18 UTC 2018


On Monday, November 5, 2018 12:42:40 PM PST Lionel Landwerlin wrote:
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Fixes: 00103db04ab879 ("intel: Fix decoding for partial STATE_BASE_ADDRESS updates.")
> ---
>  src/intel/common/gen_batch_decoder.c         | 2 +-
>  src/intel/tools/aubinator_viewer_decoder.cpp | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/intel/common/gen_batch_decoder.c b/src/intel/common/gen_batch_decoder.c
> index 90fabc2657f..27b094a7670 100644
> --- a/src/intel/common/gen_batch_decoder.c
> +++ b/src/intel/common/gen_batch_decoder.c
> @@ -215,7 +215,7 @@ handle_state_base_address(struct gen_batch_decode_ctx *ctx, const uint32_t *p)
>           surface_modify = iter.raw_value;
>        } else if (strcmp(iter.name, "Dynamic State Base Address Modify Enable") == 0) {
>           dynamic_modify = iter.raw_value;
> -      } else if (strcmp(iter.name, "Insntruction Base Address Modify Enable") == 0) {
> +      } else if (strcmp(iter.name, "Instruction Base Address Modify Enable") == 0) {
>           instruction_modify = iter.raw_value;
>        }
>     }
> diff --git a/src/intel/tools/aubinator_viewer_decoder.cpp b/src/intel/tools/aubinator_viewer_decoder.cpp
> index fb8616efc9f..2c0f5886bb4 100644
> --- a/src/intel/tools/aubinator_viewer_decoder.cpp
> +++ b/src/intel/tools/aubinator_viewer_decoder.cpp
> @@ -175,7 +175,7 @@ handle_state_base_address(struct aub_viewer_decode_ctx *ctx,
>           surface_modify = iter.raw_value;
>        } else if (strcmp(iter.name, "Dynamic State Base Address Modify Enable") == 0) {
>           dynamic_modify = iter.raw_value;
> -      } else if (strcmp(iter.name, "Insntruction Base Address Modify Enable") == 0) {
> +      } else if (strcmp(iter.name, "Instruction Base Address Modify Enable") == 0) {
>           instruction_modify = iter.raw_value;
>        }
>     }
> 

*sad trombones at self*

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

I went ahead and pushed this, too.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181105/a22245cf/attachment.sig>


More information about the mesa-dev mailing list