[Mesa-dev] [Mesa-stable] [PATCH 0/5] add support for EXT_shader_implicit_conversions

[Juan A. Suarez Romero]

On Tue, 2018-11-06 at 10:32 +0000, Emil Velikov wrote:
> On Fri, 2 Nov 2018 at 16:06, Erik Faye-Lund
> <erik.faye-lund at collabora.com> wrote:
> > On Fri, 2018-11-02 at 15:40 +0000, Emil Velikov wrote:
> > > On Tue, 30 Oct 2018 at 17:11, Erik Faye-Lund
> > > <erik.faye-lund at collabora.com> wrote:
> > > > EXT_shader_implicit_conversions is a useful extension that adds
> > > > implicit
> > > > conversions to OpenGL ES 3.1. Since it's tested excensively in
> > > > dEQP, and
> > > > Mesa already has support for implicit conversions, it seems
> > > > reasonable to
> > > > allow for the extension. This ended up mostly as code-cleanups
> > > > anyway.
> > > > 
> > > > While enabling this, one bug was discorvered due to a failing dEQP
> > > > test
> > > > (see the last patch).
> > > > 
> > > > This makes 2068 dEQP-GLE31 tests go from NotSupported to Pass on
> > > > i965.
> > > > 
> > > > No piglit regressions observed.
> > > > 
> > > > Erik Faye-Lund (5):
> > > >   glsl: add has_implicit_conversions()-helper
> > > >   glsl: add has_implicit_uint_to_int_conversion()-helper
> > > >   glsl: fall back to inexact function-match
> > > >   mesa/glsl: add support for EXT_shader_implicit_conversions
> > > >   glsl: do not allow implicit casts of unsized array initializers
> > > > 
> > > Erik, I think we'd want the hole series minus the ES extension?
> > > 
> > > The issues fixed with the final patch affect GLSL 1.30-4.60 at least.
> > > Even if there's no desktop gl tests for it.
> > > 
> > 
> > Do you mean for the 18.3 release? If so, yes that might be good. The
> > last patch alone should also fix it, it shouldn't depend on the other
> > patches...
> > 
> Technically it should be applicable for earlier series. I'll leave it
> to the guys to decide if we'd want this in 18.2 though.
> 

FWIW, all the 5 patches apply cleanly in 18.2 branch, except the former, which
requires a trivial conflict resolution.

As I'm not sure if the patches are worth for 18.2, I'll wait to know if you want
them in 18.2 or not.

	J.A.

> -Emil
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable