[Mesa-dev] [PATCH] radv/nir: avoid packing vertex outputs we can eliminate

Eric Anholt eric at anholt.net
Tue Nov 6 18:00:19 UTC 2018


Timothy Arceri <tarceri at itsqueeze.com> writes:

> On Mon, Nov 5, 2018, at 4:44 PM, Timothy Arceri wrote:
>> On 6/11/18 11:30 am, Eric Anholt wrote:
>> > Timothy Arceri <tarceri at itsqueeze.com> writes:
>> > 
>> >> For now I have only enabled this for RADV we can do it
>> >> also for radeonsi also but we need to add a CAP for it.
>> > 
>> > If we're doing this at link time, why not push the constant value from
>> > the producer into the consumer shader and then cut out the varying
>> > entirely?
>> > 
>> 
>> Maybe we could look to do this between vertex stages but we can do this 
>
> Sorry that should be: "can't do this"           
>
>> for fragment inputs (which is what this patch is for) unless they are 
>> marked as flat (which almost never happens). Or I'm I missing something?

If the vertex shader is providing a constant for all the vertices you're
interpolating between, how is that different from being flat?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181106/61f5445a/attachment.sig>


More information about the mesa-dev mailing list