[Mesa-dev] [PATCH 10/13] mesa/main: fix validation of transform-feedback overflow queries
Erik Faye-Lund
erik.faye-lund at collabora.com
Wed Nov 7 15:58:34 UTC 2018
ctx->Extensions.ARB_transform_feedback_overflow_query is set based on
the driver-capabilities, not based on the context type. We need to
check against _mesa_has_RB_transform_feedback_overflow_query(ctx)
instead to figure out if the extension is really supported.
This turns usage of GL_TRANSFORM_FEEDBACK_STREAM_OVERFLOW and
GL_TRANSFORM_FEEDBACK_OVERFLOW into errors on ES 3, as required by the
spec.
Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
---
src/mesa/main/queryobj.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
index ce3ae3401b7..d22432930d0 100644
--- a/src/mesa/main/queryobj.c
+++ b/src/mesa/main/queryobj.c
@@ -211,12 +211,12 @@ get_query_binding_point(struct gl_context *ctx, GLenum target, GLuint index)
else
return NULL;
case GL_TRANSFORM_FEEDBACK_STREAM_OVERFLOW:
- if (ctx->Extensions.ARB_transform_feedback_overflow_query)
+ if (_mesa_has_ARB_transform_feedback_overflow_query(ctx))
return &ctx->Query.TransformFeedbackOverflow[index];
else
return NULL;
case GL_TRANSFORM_FEEDBACK_OVERFLOW:
- if (ctx->Extensions.ARB_transform_feedback_overflow_query)
+ if (_mesa_has_ARB_transform_feedback_overflow_query(ctx))
return &ctx->Query.TransformFeedbackOverflowAny;
else
return NULL;
--
2.19.1
More information about the mesa-dev
mailing list