[Mesa-dev] [PATCH 12/13] mesa/main: fix validation of GL_TIMESTAMP

Erik Faye-Lund erik.faye-lund at collabora.com
Wed Nov 7 15:58:36 UTC 2018


ctx->Extensions.ARB_timer_query is set based on the driver-
capabilities, not based on the context type. We need to check
against _mesa_has_ARB_timer_query(ctx) instead to figure out
if the extension is really supported.

This shouln't have any functional effect, as this entry-point is only
valid on desktop GL in the first place. But if this gets added to a
future version of ES, this should be a step in the right direction.

Signed-off-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
---
 src/mesa/main/queryobj.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c
index 01a5504575d..87195d7ae5b 100644
--- a/src/mesa/main/queryobj.c
+++ b/src/mesa/main/queryobj.c
@@ -676,7 +676,7 @@ _mesa_GetQueryIndexediv(GLenum target, GLuint index, GLenum pname,
    }
 
    if (target == GL_TIMESTAMP) {
-      if (!ctx->Extensions.ARB_timer_query) {
+      if (!_mesa_has_ARB_timer_query(ctx)) {
          _mesa_error(ctx, GL_INVALID_ENUM, "glGetQueryARB(target)");
          return;
       }
-- 
2.19.1



More information about the mesa-dev mailing list