[Mesa-dev] [PATCH v2 04/13] intel/genxml: Add engine definition to render engine instructions (gen4)

[Toni Lönnberg]

On Tue, Nov 06, 2018 at 12:40:43PM +0000, Lionel Landwerlin wrote:
> On 31/10/2018 13:12, Toni Lönnberg wrote:
> > Instructions meant for the render engine now have a definition
> > specifying that so that can differentiate instructions meant for
> > different engines due to shared opcodes. v2: Divided into individual
> > patches for each gen ---
> 
> Just responding to this one, but this applies to all the xml changes.
> 
> I think you can set the engine="render" on the following commands :
> CONSTANT_BUFFER
> CS_URB_STATE
> MI_CLFLUSH
> MI_FLUSH
> MI_LOAD_SCAN_LINES_INCL
> MI_REPORT_PERF_COUNT
> MI_URB_ATOMIC_ALLOC
> MI_URB_CLEAR
> MI_SET_CONTEXT
> MI_STORE_URB_MEM
> MI_RS_CONTEXT
> MI_RS_CONTROL
> MI_RS_STORE_DATA_IMM
> SWTESS_BASE_ADDRESS
> URB_FENCE
> 
> Blitter only commands :
> XY_COLOR_BLT
> XY_SETUP_BLT
> XY_SRC_COPY_BLT
> XY_TEXT_IMMEDIATE_BLT
> 
> Then some special cases :
> MI_MATH : Only render on Gen7.5
> MI_WAIT_FOR_EVENT : Render only < SKL, Render & Blitter >= SKL
> MI_DISPLAY_FLIP : Blitter & Render
> 
> We're also missing MI_FLUSH_DW which is available everywhere but render
> engine (replacing MI_FLUSH).

Yeah I know as that's the first one I stumbled on when looking at some media 
workloads. There's also blitter instructions missing from a lot of the platforms 
as well as all the media instructions.

There's also other instructions missing which are shared between engines but 
use certain bits of the data differently.

> 
> Thanks!
> 
> -
> Lionel