[Mesa-dev] [PATCH 00/13] query validation fixes

[Tapani Pälli]

On 11/8/18 11:53 AM, Erik Faye-Lund wrote:
> On Thu, 2018-11-08 at 10:47 +0200, Tapani Pälli wrote:
>> On 11/8/18 10:44 AM, Erik Faye-Lund wrote:
>>> On Thu, 2018-11-08 at 08:47 +0200, Tapani Pälli wrote:
>>>> FYI there's a whole lot of tests that start to fail when this
>>>> series
>>>> running on Intel CI. It includes dEQP but also Piglit tests, can
>>>> you
>>>> do
>>>> Intel CI run or do you want me to send you results?
>>>
>>> If you mean mesa-ci.01.org, then I have no clue how to do this...
>>> If
>>> you could pass me the results, that'd be great! Or perhaps these
>>> are
>>> the results?
>>> https://mesa-ci.01.org/tpalli/builds/623/group/63a9f0ea7bb98050796b649e85481845
>>
>> Yep, this is it!
>>
> 
> OK, so at least one of those piglit failures (khr_debug-object-
> label_gles2) are bugs in the tests, where the test assumes
> glBeginQuery(GL_SAMPLES_PASSED, ...) is OK on GLES 2.
> 
> The fix for the test is pretty simple, but yeah, it's not going to pass
> until this has landed in piglit (I'll send a patch to the list soon):
> 
> ---8<---
> diff --git a/tests/spec/khr_debug/debug-object-label.c
> b/tests/spec/khr_debug/debug-object-label.c
> index e9617d719..d57315b49 100644
> --- a/tests/spec/khr_debug/debug-object-label.c
> +++ b/tests/spec/khr_debug/debug-object-label.c
> @@ -236,8 +236,13 @@ test_object_label_types()
>   	    piglit_get_gl_version() >= 30) {
>   		/* Test QUERY */
>   		glGenQueries(1, &query);
> -		glBeginQuery(GL_SAMPLES_PASSED, query);
> -		glEndQuery(GL_SAMPLES_PASSED);
> +		if
> (piglit_is_extension_supported("GL_ARB_occlusion_query")) {
> +			glBeginQuery(GL_SAMPLES_PASSED, query);
> +			glEndQuery(GL_SAMPLES_PASSED);
> +		} else {
> +			glBeginQuery(GL_ANY_SAMPLES_PASSED, query);
> +			glEndQuery(GL_ANY_SAMPLES_PASSED);
> +		}
>   		ObjectLabel(GL_QUERY, query, -1, TestLabel);
>   		GetObjectLabel(GL_QUERY, query, TestLabelLen + 1,
> &length[QUERY_IDX], label[QUERY_IDX]);
>   
> ---8<---
> 
>>> I also wouldn't mind being able to trigger test-runs manually if
>>> some
>>> credentials or whatnot could be set up ;)
>>>
>>
>> I'm not sure how this process goes but if you want me to do re-run
>> that's fine.
> 
> Would you mind re-run with this branch?
> https://gitlab.freedesktop.org/kusma/mesa/tree/queryobj-fixes
> 
> It's what I sent + 4 fixues.
> 

Sure, just started a new build. Will let you know, when it finishes.

// Tapani