[Mesa-dev] [PATCH 1/7] spirv/nir: update Xfb decoration comment

Alejandro PiƱeiro apinheiro at igalia.com
Thu Nov 8 13:22:12 UTC 2018


Although it is true that Vulkan doesn't support transform feedback
yet, spirv to nir is handling it due ARB_gl_spirv support. Having said
so, those decorations are handled elsewhere.
---
 src/compiler/spirv/spirv_to_nir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
index 96ff09c3659..140e98eba27 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -774,7 +774,7 @@ struct_member_decoration_cb(struct vtn_builder *b,
 
    case SpvDecorationXfbBuffer:
    case SpvDecorationXfbStride:
-      vtn_warn("Vulkan does not have transform feedback");
+      /* Handled at vtn_variables.c, apply_var_decoration */
       break;
 
    case SpvDecorationCPacked:
-- 
2.14.1



More information about the mesa-dev mailing list