[Mesa-dev] [PATCH v2 00/13] query validation fixes

Tapani Pälli tapani.palli at intel.com
Fri Nov 9 05:58:23 UTC 2018


Thanks, _mesa_has makes things a lot cleaner and simpler to manage;

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

On 11/8/18 2:42 PM, Erik Faye-Lund wrote:
> Here's v2 of this series. Changes are as follows:
> 
> - 5/13: also check for ARB_occlusion_query2, for core-contexts
> - 8/13: also check for EXT_disjoint_timer_query, for gles-contexts
> - 9/13: also check for OES_geometry_shader, for gles-contexts
> - 12/13: also check for EXT_disjoint_timer_query, for gles-contexts
> 
> In addition, there's regression in a piglit-test, but that test is wrong
> and uses invalid queries on GLES. A patch for that test has been sent to
> the piglit mailing list, here:
> 
> https://patchwork.freedesktop.org/series/52216/
> 
> Thanks to Tapani Pälli for testing this on the intel-ci system :)
> 
> Erik Faye-Lund (13):
>    mesa/main: correct requirement for EXT_occlusion_query_boolean
>    mesa/main: correct year for EXT_occlusion_query_boolean
>    mesa/main: use non-prefixed enums for consistency
>    mesa/main: simplify pipeline-statistics query validation
>    mesa/main: fix validation of GL_SAMPLES_PASSED
>    mesa/main: fix validation of GL_ANY_SAMPLES_PASSED
>    mesa/main: fix validation of GL_ANY_SAMPLES_PASSED_CONSERVATIVE
>    mesa/main: fix validation of GL_TIME_ELAPSED
>    mesa/main: fix validation of transform-feedback queries
>    mesa/main: fix validation of transform-feedback overflow queries
>    mesa/main: fix validation of ARB_query_buffer_object
>    mesa/main: fix validation of GL_TIMESTAMP
>    mesa/main: remove overly strict query-validation
> 
>   src/mesa/main/extensions_table.h |   2 +-
>   src/mesa/main/queryobj.c         | 112 ++++++++++++++-----------------
>   2 files changed, 52 insertions(+), 62 deletions(-)
> 


More information about the mesa-dev mailing list