[Mesa-dev] [PATCH 1/5] intel/aub_read: remove useless breaks

[Eric Engestrom]

On Friday, 2018-11-09 16:49:09 +0000, Lionel Landwerlin wrote:
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

`return` in indeed the one we need to keep here.
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>

> ---
>  src/intel/tools/aub_read.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/src/intel/tools/aub_read.c b/src/intel/tools/aub_read.c
> index d83e88ddced..cde6cb4ba03 100644
> --- a/src/intel/tools/aub_read.c
> +++ b/src/intel/tools/aub_read.c
> @@ -219,27 +219,21 @@ handle_memtrace_reg_write(struct aub_read *read, const uint32_t *p)
>     case 0x2510: /* render elsq0 lo */
>        read->render_elsp[3] = value;
>        return;
> -      break;
>     case 0x2514: /* render elsq0 hi */
>        read->render_elsp[2] = value;
>        return;
> -      break;
>     case 0x12510: /* video elsq0 lo */
>        read->video_elsp[3] = value;
>        return;
> -      break;
>     case 0x12514: /* video elsq0 hi */
>        read->video_elsp[2] = value;
>        return;
> -      break;
>     case 0x22510: /* blitter elsq0 lo */
>        read->blitter_elsp[3] = value;
>        return;
> -      break;
>     case 0x22514: /* blitter elsq0 hi */
>        read->blitter_elsp[2] = value;
>        return;
> -      break;
>     case 0x2550: /* render elsc */
>        engine = GEN_ENGINE_RENDER;
>        context_descriptor = (uint64_t)read->render_elsp[2] << 32 |
> -- 
> 2.19.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev