[Mesa-dev] [PATCH mesa 3/3] meson: fix wayland-less builds

[Emil Velikov]

On Sun, 11 Nov 2018 at 18:39, Eric Engestrom <eric.engestrom at intel.com> wrote:
>
> On Thursday, 2018-10-11 16:36:15 +0100, Eric Engestrom wrote:
> > Those empty variables in the !wayland case are useless and running that
> > meson.build with them breaks the build:
> >
> >   [287/850] Generating wayland-drm-client-protocol.h with a custom command.
> >   FAILED: src/egl/wayland/wayland-drm/wayland-drm-client-protocol.h
> >   client-header ../src/egl/wayland/wayland-drm/wayland-drm.xml src/egl/wayland/wayland-drm/wayland-drm-client-protocol.h
> >   /bin/sh: client-header: command not found
> >   ninja: build stopped: subcommand failed.
> >
> > Fixes: d1992255bb29054fa5176 "meson: Add build Intel "anv" vulkan driver"
> > Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> > ---
> > Kind of amazed that no one has tried to build with wayland disabled
> > since meson was introduced, but I guess it's a good thing ^^'
>
> Humble ping for this series?
> It is currently impossible to build Mesa without support for wayland,
> which I think is quite an important bug :)
>
I've always wondered if/how null_dep works.

The series looks good IMHO, for the lot.
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

May be worth double-checking with Dylan.

HTH
Emil