[Mesa-dev] [PATCH 16/28] Replace IROUND_POS with _mesa_roundevenf

Dylan Baker dylan at pnwbakers.com
Mon Nov 12 17:22:13 UTC 2018


Quoting Erik Faye-Lund (2018-11-12 04:51:47)
> On Fri, 2018-11-09 at 10:40 -0800, Dylan Baker wrote:
> > Which has the same behavior.
> 
> Does it? I'm not so sure... IROUND_POS seems to round to nearest
> integer depending on the FPU rounding mode, _mesa_roundevenf rounds to
> the nearest *even* value regardless of the FPU rounding mode, no?
> 
> I'm not sure if it matters or not, but *at least* point that out in the
> commit message. Unless I'm missing something, of course...

I should put it in the commit message, but there is a comment in rounding.h that
if you change the rounding mode you get to keep the pieces. I'll add that to the
commit message.

Dylan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181112/105e2f2b/attachment.sig>


More information about the mesa-dev mailing list