[Mesa-dev] [PATCH 4/5] nir: Make nir_lower_clip_vs optionally work with variables.

[Eric Anholt]

Kenneth Graunke <kenneth at whitecape.org> writes:

> The way nir_lower_clip_vs() works with store_output intrinsics makes a
> ton of assumptions about the driver_location field.
>
> In i965, I'd rather do this lowering early and work with variables.
> ir3 and vc4 could probably do that as well, but I'm not sure exactly
> what paths would need updating, so for now, handle both methods.
> ---
>  src/compiler/nir/nir.h                      |  2 +-
>  src/compiler/nir/nir_lower_clip.c           | 45 ++++++++++++++++-----
>  src/gallium/drivers/freedreno/ir3/ir3_nir.c |  2 +-
>  src/gallium/drivers/vc4/vc4_program.c       |  3 +-

If you hit src/broadcom/compiler/vir.c as well, the series is:

Reviewed-by: Eric Anholt <eric at anholt.net>

Switching vc4/v3d stuff over to variables has been going well and
showing wins -- I think we should probably finish that work and then
simplify these paths by moving this lowering before lower_io.

In the past, I thought we would want to lower_io at gallium state
creation time, since it was some compile work we could do at
compile/link instead of draw.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181112/ed15eac9/attachment.sig>