[Mesa-dev] [PATCH v2 3/4] dri: add AYUV format

[Lionel Landwerlin]

On 13/11/2018 12:04, Tapani Pälli wrote:
>
> On 11/13/18 1:43 PM, Lionel Landwerlin wrote:
>> I think this chunk (or the whole patch) should be cherry picked to 
>> stable.
>> Otherwise we get a BAD_ATTRIBUTE error for trying to create an AYUV 
>> EGLImage.
>> We should have BAD_MATCH instead.
>
> Or should we change the reported error code in places where this is 
> called? That seems like an existing bug, things wouldn't work 
> correctly if someone adds a new format to drm_fourcc.h.


Sounds fair, running a patch through CI.


>
>> -
>> Lionel
>>
>> On 09/11/2018 10:55, Lionel Landwerlin wrote:
>>> diff --git a/src/egl/drivers/dri2/egl_dri2.c 
>>> b/src/egl/drivers/dri2/egl_dri2.c
>>> index 87e1a704c6e..3b63aebbf9a 100644
>>> --- a/src/egl/drivers/dri2/egl_dri2.c
>>> +++ b/src/egl/drivers/dri2/egl_dri2.c
>>> @@ -2278,6 +2278,7 @@ dri2_num_fourcc_format_planes(EGLint format)
>>>      case DRM_FORMAT_YVYU:
>>>      case DRM_FORMAT_UYVY:
>>>      case DRM_FORMAT_VYUY:
>>> +   case DRM_FORMAT_AYUV:
>>>         return 1;
>>>      case DRM_FORMAT_NV12:
>>
>>
>