[Mesa-dev] [PATCH] egl/dri: fix error value with unknown drm format

Lionel Landwerlin lionel.g.landwerlin at intel.com
Tue Nov 13 15:49:06 UTC 2018


On 13/11/2018 15:43, Emil Velikov wrote:
> On Tue, 13 Nov 2018 at 14:11, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> According to the EGL_EXT_image_dma_buf_import spec, creating an EGL
>> image with a DRM format not supported should yield the BAD_MATCH
>> error :
>>
>> "
>>         * If <target> is EGL_LINUX_DMA_BUF_EXT, and the EGL_LINUX_DRM_FOURCC_EXT
>>           attribute is set to a format not supported by the EGL, EGL_BAD_MATCH
>>           is generated.
>> "
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> Fixes: 20de7f9f226401 ("egl/dri2: support for creating images out of dma buffers")
> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>
> Great catch Lionel. Out of curiosity, how did you spot this?
>
> -Emil
>

Running :

ext_image_dma_buf_import-sample_yuv -fmt=AYUV

on an older driver.


-

Lionel



More information about the mesa-dev mailing list