[Mesa-dev] [PATCH 2/9] bin/get-pick-list.sh: prefix output with "[stable] "

[Juan A. Suarez Romero]

On Thu, 2018-11-08 at 15:05 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> With later commits we'll fold all the different scripts into one.
> Add the explicit prefix, so that we know the origin of the nomination
> 
> v2:
>  - pass the sha as argument to the function
>  - drop $tag = none an else statment (Juan)
>  - grep -q instead of using a variable (Eric)
>  - print the tag and commit oneline separately (Eric)
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
>  bin/get-pick-list.sh | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> diff --git a/bin/get-pick-list.sh b/bin/get-pick-list.sh
> index ba741cc4114..6ab2a54dd4c 100755
> --- a/bin/get-pick-list.sh
> +++ b/bin/get-pick-list.sh
> @@ -7,6 +7,14 @@
>  # $ bin/get-pick-list.sh
>  # $ bin/get-pick-list.sh > picklist
>  # $ bin/get-pick-list.sh | tee picklist
> +#
> +# The output is as follows:
> +# [nominaiton_type] commit_sha commit summary
      ^ nomination

> +
> +is_stable_nomination()
> +{
> +	git show --summary "$1" | grep -q -i -o "CC:.*mesa-stable"
> +}
>  
>  # Use the last branchpoint as our limit for the search
>  latest_branchpoint=`git merge-base origin/master HEAD`
> @@ -32,6 +40,14 @@ do
>  		continue
>  	fi
>  
> +	tag=none

 I think we don't need this "tag=none" anymore.

> +	if is_stable_nomination "$sha"; then
> +		tag=stable
> +	else
> +		continue
> +	fi
> +
> +	printf "[ %8s ] " "$tag"
>  	git --no-pager show --summary --oneline $sha
>  done
>