[Mesa-dev] [PATCH 10/9] bin/get-pick-list.sh: handle reverts prior to the branchpoint

Juan A. Suarez Romero jasuarez at igalia.com
Thu Nov 15 09:28:14 UTC 2018


On Wed, 2018-11-14 at 18:52 +0000, Emil Velikov wrote:
> On Wed, 14 Nov 2018 at 18:51, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> > From: Emil Velikov <emil.velikov at collabora.com>
> > 
> > Currently we detect when a breaking commit:
> >  - has landed in stable, and
> >  - is referenced by a untagged fix in master
> > 
> > Yet we did not consider the case of breaking commit:
> >  - prior to the branchpoint, and
> >  - is referenced by a untagged fix in master
> > 
> > Addressing the latter is extremely slow since due to the size of the
> > lookup.
> > 
> > That said, we can trivially use the existing is_sha_nomination()
> > helper to catch reverts.
> > 
> > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> 
> Juan,
> Please you skim over the updated series and this add-on patch?
> They've caught a few issues that may be present in 18.2.
> 

Sorry for the delay.

Reviewed-by: Juan A. Suarez <jasuarez at igalia.com>


> Emil
> 



More information about the mesa-dev mailing list