[Mesa-dev] [PATCH 3/3] radv: allow to use DCC for MSAA x4 and x8 with the debug option
Samuel Pitoiset
samuel.pitoiset at gmail.com
Thu Nov 15 14:35:56 UTC 2018
No CTS regressions on GFX8 now. Still some fails when resolving
DCC/MSAA textures on GFX9.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
---
src/amd/vulkan/radv_image.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index 64346aa340..a71b65edb3 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -157,12 +157,11 @@ radv_use_dcc_for_image(struct radv_device *device,
if (create_info->scanout)
return false;
- /* FIXME: DCC for MSAA with 4x and 8x samples doesn't work yet, while
- * 2x can be enabled with an option.
+ /* TODO: Enable DCC/MSAA by default. This requires fixing fast color
+ * clears and to investigate about performance.
*/
- if (pCreateInfo->samples > 2 ||
- (pCreateInfo->samples == 2 &&
- !device->physical_device->dcc_msaa_allowed))
+ if (pCreateInfo->samples >= 2 &&
+ !device->physical_device->dcc_msaa_allowed)
return false;
/* Determine if the formats are DCC compatible. */
--
2.19.1
More information about the mesa-dev
mailing list