[Mesa-dev] [PATCH] intel/fs,vec4: Fix a compiler warning

[apinheiro]

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>

On 16/11/18 16:25, Jason Ekstrand wrote:
> ../src/intel/compiler/brw_fs_nir.cpp:3534:46: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘int’ [-Wsign-compare]
>        assert(nir_intrinsic_write_mask(instr) ==
>               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
>               (1 << instr->num_components) - 1);
>               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> This was caused by 6339aba775ecdc which added these completely valid
> checks.  However clang likes to complain about signedness mismatches.
>
> Fixes: 6339aba775ecdc "intel/compiler: Lower SSBO and shared..."
> ---
>  src/intel/compiler/brw_fs_nir.cpp   | 4 ++--
>  src/intel/compiler/brw_vec4_nir.cpp | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/intel/compiler/brw_fs_nir.cpp b/src/intel/compiler/brw_fs_nir.cpp
> index 84d0c6be6c3..6eb68794f58 100644
> --- a/src/intel/compiler/brw_fs_nir.cpp
> +++ b/src/intel/compiler/brw_fs_nir.cpp
> @@ -3514,7 +3514,7 @@ fs_visitor::nir_emit_cs_intrinsic(const fs_builder &bld,
>        val_reg.type = brw_reg_type_from_bit_size(bit_size, BRW_REGISTER_TYPE_UD);
>  
>        assert(nir_intrinsic_write_mask(instr) ==
> -             (1 << instr->num_components) - 1);
> +             (1u << instr->num_components) - 1);
>        if (nir_intrinsic_align(instr) >= 4) {
>           assert(nir_src_bit_size(instr->src[0]) == 32);
>           assert(nir_src_num_components(instr->src[0]) <= 4);
> @@ -4070,7 +4070,7 @@ fs_visitor::nir_emit_intrinsic(const fs_builder &bld, nir_intrinsic_instr *instr
>        val_reg.type = brw_reg_type_from_bit_size(bit_size, BRW_REGISTER_TYPE_UD);
>  
>        assert(nir_intrinsic_write_mask(instr) ==
> -             (1 << instr->num_components) - 1);
> +             (1u << instr->num_components) - 1);
>        if (nir_intrinsic_align(instr) >= 4) {
>           assert(nir_src_bit_size(instr->src[0]) == 32);
>           assert(nir_src_num_components(instr->src[0]) <= 4);
> diff --git a/src/intel/compiler/brw_vec4_nir.cpp b/src/intel/compiler/brw_vec4_nir.cpp
> index 26ca2ddd8dc..4bb4d0d4074 100644
> --- a/src/intel/compiler/brw_vec4_nir.cpp
> +++ b/src/intel/compiler/brw_vec4_nir.cpp
> @@ -503,7 +503,7 @@ vec4_visitor::nir_emit_intrinsic(nir_intrinsic_instr *instr)
>        /* brw_nir_lower_mem_access_bit_sizes takes care of this */
>        assert(nir_src_bit_size(instr->src[0]) == 32);
>        assert(nir_intrinsic_write_mask(instr) ==
> -             (1 << instr->num_components) - 1);
> +             (1u << instr->num_components) - 1);
>  
>        src_reg surf_index = get_nir_ssbo_intrinsic_index(instr);
>        src_reg offset_reg = retype(get_nir_src_imm(instr->src[2]),
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pEpkey.asc
Type: application/pgp-keys
Size: 1546 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181117/a44e6486/attachment-0001.key>