[Mesa-dev] [PATCH] virgl: Use file descriptor instead of un-allocated object

[Robert Foss]

Hey Gert,

Nice catch!

Reviewed-by: Robert Foss <robert.foss at collabora.com>


On 2018-11-19 10:56, Gert Wollny wrote:
> From: Gert Wollny <gert.wollny at collabora.com>
> 
> The structure qdws is not allocated at this point, nor is the
> file descriptor set to it's member. Use the fd directly instead.
> 
> Fixes:  d1a1c21e7621b5177febf191fcd3d3b8ef69dc96
>      virgl: native fence fd support
> 
> Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
> ---
>   src/gallium/winsys/virgl/drm/virgl_drm_winsys.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
> index 2c02d3ccd7..26de8c702d 100644
> --- a/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
> +++ b/src/gallium/winsys/virgl/drm/virgl_drm_winsys.c
> @@ -892,7 +892,7 @@ virgl_drm_winsys_create(int drmFD)
>      if (ret < 0 || !gl)
>         return NULL;
>   
> -   drm_version = virgl_drm_get_version(qdws->fd);
> +   drm_version = virgl_drm_get_version(drmFD);
>      if (drm_version < 0)
>         return NULL;
>   
>