[Mesa-dev] [PATCH] i965:use FRAMEBUFFER_UNSUPPORTED instead of FRAMEBUFFER_INCOMPLETE_DIMENSIONS
Iago Toral
itoral at igalia.com
Mon Nov 19 10:00:46 UTC 2018
Thanks!
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
On Mon, 2018-11-19 at 10:36 +0100, Gert Wollny wrote:
> FRAMEBUFFER_INCOMPLETE_DIMENSIONS is not supported for GLES 3.0 and
> later and
> not defined for Desktop OpenGL. Instead use FRAMEBUFFER_UNSUPPORTED
> like it
> was done before.
>
> Thanks to Iago Toral and Andrey Simiklit for pointing out the problem
> and the
> details.
>
> Fixes: ebcde3454552adc6d3fea8af2207aafaba857796
> i965: be more specific about FBO completeness errors
> Signed-off-by: Gert Wollny <gert.wollny at collabora.com>
> ---
> src/mesa/drivers/dri/i965/intel_fbo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_fbo.c
> b/src/mesa/drivers/dri/i965/intel_fbo.c
> index febd1aca98..7e40d61a47 100644
> --- a/src/mesa/drivers/dri/i965/intel_fbo.c
> +++ b/src/mesa/drivers/dri/i965/intel_fbo.c
> @@ -693,7 +693,7 @@ intel_validate_framebuffer(struct gl_context
> *ctx, struct gl_framebuffer *fb)
> d_depth != s_depth ||
> depthRb->mt_level != stencilRb->mt_level ||
> depthRb->mt_layer != stencilRb->mt_layer) {
> - fbo_incomplete(fb, GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS,
> + fbo_incomplete(fb, GL_FRAMEBUFFER_UNSUPPORTED,
> "FBO incomplete: depth and stencil must
> match in"
> "width, height, depth, LOD and layer\n");
> }
More information about the mesa-dev
mailing list