[Mesa-dev] [PATCH] meson: Don't set -Wall

Juan A. Suarez Romero jasuarez at igalia.com
Mon Nov 19 15:17:14 UTC 2018


On Fri, 2018-11-09 at 13:28 -0800, Dylan Baker wrote:
> meson does this for you with it's warn levels, so we don't need to set
> it ourselves.
> 
> Fixes: d1992255bb29054fa51763376d125183a9f602f3
>        ("meson: Add build Intel "anv" vulkan driver")


Hi.

I've cherry-picked this commit for next 18.2 release, after solving a trivial
conflict:

https://gitlab.freedesktop.org/mesa/mesa/commit/93b2a277ab61e1de5946745f9a33bf07982fbd30


	J.A.

> ---
>  meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 18667988bac..dabfb9abddd 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -787,7 +787,7 @@ endif
>  
>  # Check for generic C arguments
>  c_args = []
> -foreach a : ['-Wall', '-Werror=implicit-function-declaration',
> +foreach a : ['-Werror=implicit-function-declaration',
>               '-Werror=missing-prototypes', '-Werror=return-type',
>               '-fno-math-errno',
>               '-fno-trapping-math', '-Qunused-arguments']
> @@ -809,7 +809,7 @@ endif
>  
>  # Check for generic C++ arguments
>  cpp_args = []
> -foreach a : ['-Wall', '-Werror=return-type',
> +foreach a : ['-Werror=return-type',
>               '-fno-math-errno', '-fno-trapping-math',
>               '-Qunused-arguments']
>    if cpp.has_argument(a)



More information about the mesa-dev mailing list