[Mesa-dev] [PATCH 4/4] i965: Add support for and expose EXT_texture_sRGB_R8

Gert Wollny gert.wollny at collabora.com
Tue Nov 20 09:32:41 UTC 2018


Am Montag, den 19.11.2018, 12:18 -0800 schrieb Mark Janes:
> Eric Engestrom <eric.engestrom at intel.com> writes:
> 
> > Patches 1-3 are:
> > Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
> > 
> > Patch 4 is:
> > Acked-by: Eric Engestrom <eric.engestrom at intel.com>
> 
> For external contributors, patches like this should not be R-B or
> Acked unless they have been tested in the i965 CI.
> 
> This series failed to build when pushed, and regressed many tests
> when the compilation error was corrected.
> 
>   https://bugs.freedesktop.org/show_bug.cgi?id=108805

Sorry about that, the compilation error was a stupid mistake that I got
deviating from my usual patch submission work flow. About the bug, I'll
comment there, but the crashes don't seem to be related to the
extension, but to the change of the error number, which seems very
strange to me. I'm updating the CTS now to check with the latest
version.

> Gert, we can set up a CI build for you if you feel like it would be
> helpful to your work.  Eric can also test your patches by pushing
> them to his CI project.
I don't think I'll do that many contributions specifically to the Intel
driver, but if I have a series that directly affects Intel I'll ping
Eric to run the Ci next time. 

Best, 
Gert



More information about the mesa-dev mailing list