[Mesa-dev] [PATCH 10/10] mesa: Remove unneeded bitfield widths from the VAO.

[Timothy Arceri]

On 20/11/18 10:10 pm, Mathias Fröhlich wrote:
> Hi,
> 
>> Yes thank you. In more actively changed code I guess it would make more
>> sense to leave the bitfield width but as this is unlikely to change much
>> in future you have convinced me its probably not worth leaving it. Thanks.
> 
> Oh, you mean as it would have documented what value ranges you can put into?
> 
> If you like to know that, I can extend the comments also to mention the value range.
> So that any future introduction of a bit width does not need to check what can
> legally end in there ...

I have mixed feeling about the comment as things like that tend to get 
out of date. I think this change is fine as is.

By the way thanks for all your work cleaning all this stuff up. I 
haven't been actively reviewing but I've been skimming over your various 
series, things are looking much better.

> 
> best
> 
> Mathias
> 
>