[Mesa-dev] [PATCH mesa 00/13] Make standard function available on non-standard platforms

Eric Engestrom eric.engestrom at intel.com
Tue Nov 20 13:11:00 UTC 2018


... instead of making standard platforms use non-standard functions.

This also reduces the likelihood of someone forgetting to use the
non-standard function, and reduces the fix to a simple #include.

Changes generated using this shell function for each function name:
  fix() {
    files=$(ag -lw util_$1)
    sed s/'\<util_'$1'\>'/$1/g -i $files
    git add -up $files
    git commit -sm 'util: use standard name for '$1'()'
  }

Eric Engestrom (13):
  util: use standard name for strchrnul()
  util: use standard name for strcasecmp()
  util: use standard name for strdup()
  util: use standard name for strstr()
  util: use standard name for strncat()
  util: use standard name for strncmp()
  util: use standard name for strcmp()
  util: use standard name for strchr()
  util: use standard name for sprintf()
  util: use standard name for vasprintf()
  util: use standard name for vsprintf()
  util: use standard name for snprintf()
  util: use standard name for vsnprintf()

 src/amd/common/ac_debug.c                     |  2 +-
 .../glsl/ir_builder_print_visitor.cpp         |  2 +-
 src/compiler/glsl/ir_print_visitor.cpp        | 12 ++---
 src/compiler/glsl/link_interface_blocks.cpp   |  4 +-
 src/compiler/glsl/linker.cpp                  |  2 +-
 .../glsl/opt_dead_builtin_varyings.cpp        | 10 ++--
 src/compiler/glsl_types.cpp                   | 10 ++--
 src/gallium/auxiliary/draw/draw_llvm.c        | 10 ++--
 src/gallium/auxiliary/driver_ddebug/dd_util.h |  4 +-
 src/gallium/auxiliary/driver_trace/tr_dump.c  |  2 +-
 .../auxiliary/gallivm/lp_bld_arit_overflow.c  |  2 +-
 .../auxiliary/gallivm/lp_bld_debug.cpp        |  4 +-
 src/gallium/auxiliary/gallivm/lp_bld_debug.h  |  2 +-
 src/gallium/auxiliary/gallivm/lp_bld_gather.c |  2 +-
 src/gallium/auxiliary/gallivm/lp_bld_init.c   |  4 +-
 src/gallium/auxiliary/gallivm/lp_bld_intr.c   |  4 +-
 src/gallium/auxiliary/gallivm/lp_bld_printf.c |  8 +--
 .../auxiliary/gallivm/lp_bld_sample_soa.c     |  2 +-
 .../auxiliary/gallivm/lp_bld_tgsi_soa.c       |  2 +-
 src/gallium/auxiliary/hud/hud_context.c       |  4 +-
 .../auxiliary/pipe-loader/pipe_loader.c       |  6 +--
 src/gallium/auxiliary/postprocess/pp_mlaa.c   |  2 +-
 src/gallium/auxiliary/tgsi/tgsi_dump.c        |  2 +-
 src/gallium/auxiliary/util/u_async_debug.c    |  2 +-
 src/gallium/auxiliary/util/u_debug_describe.c | 22 ++++----
 src/gallium/auxiliary/util/u_debug_flush.c    |  2 +-
 src/gallium/auxiliary/util/u_debug_image.c    |  2 +-
 src/gallium/auxiliary/util/u_debug_symbol.c   | 10 ++--
 src/gallium/auxiliary/util/u_dump_state.c     |  2 +-
 src/gallium/auxiliary/util/u_log.c            |  2 +-
 src/gallium/auxiliary/util/u_network.c        |  2 +-
 src/gallium/auxiliary/util/u_simple_shaders.c |  2 +-
 src/gallium/auxiliary/util/u_tests.c          |  4 +-
 src/gallium/drivers/etnaviv/etnaviv_screen.c  |  2 +-
 .../drivers/freedreno/freedreno_batch.c       |  2 +-
 .../drivers/freedreno/freedreno_screen.c      |  2 +-
 src/gallium/drivers/i915/i915_fpc_translate.c |  2 +-
 src/gallium/drivers/i915/i915_screen.c        |  2 +-
 src/gallium/drivers/llvmpipe/lp_flush.c       |  4 +-
 src/gallium/drivers/llvmpipe/lp_rast.c        |  2 +-
 src/gallium/drivers/llvmpipe/lp_screen.c      |  2 +-
 src/gallium/drivers/llvmpipe/lp_state_fs.c    |  4 +-
 src/gallium/drivers/llvmpipe/lp_state_setup.c |  2 +-
 src/gallium/drivers/llvmpipe/lp_test_arit.c   |  2 +-
 src/gallium/drivers/llvmpipe/lp_test_format.c |  2 +-
 src/gallium/drivers/nouveau/nouveau_screen.c  |  2 +-
 src/gallium/drivers/radeonsi/si_debug.c       |  2 +-
 src/gallium/drivers/radeonsi/si_shader.c      |  2 +-
 src/gallium/drivers/softpipe/sp_flush.c       |  4 +-
 src/gallium/drivers/svga/svga_msg.c           |  2 +-
 src/gallium/drivers/svga/svga_pipe_flush.c    |  4 +-
 src/gallium/drivers/svga/svga_sampler_view.c  |  2 +-
 src/gallium/drivers/svga/svga_screen.c        |  8 +--
 src/gallium/drivers/swr/swr_screen.cpp        |  2 +-
 src/gallium/drivers/vc4/vc4_bufmgr.c          |  2 +-
 src/intel/vulkan/anv_device.c                 |  4 +-
 src/mesa/program/symbol_table.c               |  4 +-
 src/util/string_buffer.c                      |  2 +-
 src/util/u_debug.c                            | 38 +++++++-------
 src/util/u_queue.c                            |  6 +--
 src/util/u_string.h                           | 52 ++++++++-----------
 61 files changed, 154 insertions(+), 162 deletions(-)

-- 
Cheers,
  Eric



More information about the mesa-dev mailing list