[Mesa-dev] [PATCH mesa 1/2] virgl: add missing function parameter

[Robert Foss]

Hey Eric,

On 2018-11-20 13:36, Eric Engestrom wrote:
> Fixes: d1a1c21e7621b5177feb "virgl: native fence fd support"
> Cc: Robert Foss <robert.foss at collabora.com>
> Cc: Emil Velikov <emil.velikov at collabora.com>
> Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
> ---
> I don't know if something should be done with the fd type in this
> function, so one of you might want to send another patch to fix this?
> Otherwise, at least this fixes the function signature.
> ---
>   src/gallium/drivers/virgl/virgl_context.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/virgl/virgl_context.c b/src/gallium/drivers/virgl/virgl_context.c
> index 9be7775abd3178d4b625..f6849598ee525f5728eb 100644
> --- a/src/gallium/drivers/virgl/virgl_context.c
> +++ b/src/gallium/drivers/virgl/virgl_context.c
> @@ -1030,7 +1030,9 @@ static void virgl_set_shader_buffers(struct pipe_context *ctx,
>   }
>   
>   static void virgl_create_fence_fd(struct pipe_context *ctx,
> -			        struct pipe_fence_handle **fence, int fd)
> +                                  struct pipe_fence_handle **fence,
> +                                  int fd,
> +                                  enum pipe_fd_type type)
>   {
>      struct virgl_screen *rs = virgl_screen(ctx->screen);


I think maybe an assert should be added, so we would end
up with something like this:

static void virgl_create_fence_fd(struct pipe_context *ctx,
                                   struct pipe_fence_handle **fence,
                                   int fd,
                                   enum pipe_fd_type type)
{
    assert(type == PIPE_FD_TYPE_NATIVE_SYNC);
    struct virgl_screen *rs = virgl_screen(ctx->screen);

    *fence = rs->vws->cs_create_fence(rs->vws, fd);
}