[Mesa-dev] [PATCH 08/18] mapi/new: don't print info we don't need for ES1/ES2

[Dylan Baker]

Quoting Emil Velikov (2018-11-21 04:04:05)
> There is no need for the noop function, the public_stubs table or table
> size defines. Remove those.
> 
> Might what to look and merge this back to GLVND - from a quick look
> they don't need them either.
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  src/mapi/new/gen_gldispatch_mapi.py | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mapi/new/gen_gldispatch_mapi.py b/src/mapi/new/gen_gldispatch_mapi.py
> index be7b7495909..b370559024d 100755
> --- a/src/mapi/new/gen_gldispatch_mapi.py
> +++ b/src/mapi/new/gen_gldispatch_mapi.py
> @@ -63,9 +63,10 @@ typedef void (APIENTRY  *GLDEBUGPROCKHR)(GLenum source,GLenum type,GLuint id,GLe
>  """.lstrip("\n"))
>  
>      print(generate_defines(functions))
> -    print(generate_table(functions, allFunctions))
> -    print(generate_noop_array(functions))
> -    print(generate_public_stubs(functions))
> +    if (target not in ("glesv1", "glesv2")):

No parens around the condition, and use either a list or a set (not a tuple) for
the container:
if target not in {"glesv1", "glesv2"}:

tuples are for heterogenous data (that is, the position is important, and the
types are different), sets and lists are for homogenous data.

> +        print(generate_table(functions, allFunctions))
> +        print(generate_noop_array(functions))
> +        print(generate_public_stubs(functions))
>      print(generate_public_entries(functions))
>      print(generate_stub_asm_gcc(functions))
>  
> -- 
> 2.19.1
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20181121/4b978fc1/attachment.sig>