[Mesa-dev] [PATCH] intel/compiler: Always print flag subregister number

[Matt Turner]

On Thu, Nov 15, 2018 at 2:16 PM Sagar Ghuge <sagar.ghuge at intel.com> wrote:
>
> While disassembling the predicate always print flag subregister number
> to keep grammar same across the generation for assembler tool.

That's reasonable.

> Signed-off-by: Sagar Ghuge <sagar.ghuge at intel.com>
> ---
>  src/intel/compiler/brw_disasm.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/intel/compiler/brw_disasm.c b/src/intel/compiler/brw_disasm.c
> index 6c79fec0a1..a218e1451c 100644
> --- a/src/intel/compiler/brw_disasm.c
> +++ b/src/intel/compiler/brw_disasm.c
> @@ -1486,8 +1486,7 @@ brw_disassemble_inst(FILE *file, const struct gen_device_info *devinfo,
>        err |= control(file, "predicate inverse", pred_inv,
>                       brw_inst_pred_inv(devinfo, inst), NULL);
>        format(file, "f%"PRIu64, devinfo->gen >= 7 ? brw_inst_flag_reg_nr(devinfo, inst) : 0);
> -      if (brw_inst_flag_subreg_nr(devinfo, inst))
> -         format(file, ".%"PRIu64, brw_inst_flag_subreg_nr(devinfo, inst));
> +      format(file, ".%"PRIu64, brw_inst_flag_subreg_nr(devinfo, inst));

I would combine the two format() calls here.

>        if (brw_inst_access_mode(devinfo, inst) == BRW_ALIGN_1) {
>           err |= control(file, "predicate control align1", pred_ctrl_align1,
>                          brw_inst_pred_control(devinfo, inst), NULL);
> --

In the same function (brw_disassemble_inst) a little below here there
is an additional place where we conditionally print the flag
subregister number. I suspect you want to change it too.